NXDOMAIN response flag for empty answer #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhs, any plans to merge this? Is this project still maintained? |
|
I've merged into my fork, which also supports serving over ipv6 addresses. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you deliberately send an empty result using
res.end();the default convenience behavior would set the DNS return code 0 ("NOERROR"). Instead, the return code 3 ("NXDOMAIN") would be more appropriate. While technically, NOERROR is fine even if the response contains no answer, this patch will avoid the "Zero answer bug" which is already mentioned in RFC 1536.