Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #149 Pinch zoom on IOS #160

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ryuuzake
Copy link

scale from iOS behaves differently between expo and native. When using expo, the scale value is between 0 and 1. But when using native, the scale value is above 1.

To solve this issue, I proposed to change the maxScale value to 3. The value 3 is suggested in #149.
from my testing, it actually doesn't matter to use what value as long as it's above 1

Copy link

@Hassan-Riaz Hassan-Riaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryuuzake
You can have this maxScale passed from font side so its configurable. And of-course there will be a default value
Same configuration will be applied to android as well

@ryuuzake
Copy link
Author

ryuuzake commented Oct 5, 2022

@Hassan-Riaz I changes the code to pass the maxScale props from ImageViewing so now it's configurable. Because of it, I remove the maxScale logic in ImageItem.ios.tsx. Do we still need it? If so, I should add some kind of default logic.

@arjovanramshorst
Copy link

Is this going to be merged/released anytime soon? We are waiting on this functionality and patching the package does not seem like an optimal solution if the fix is here already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants