WIP: Add config to TestCpg and filter php files #2733
Conversation
johannescoetzee
changed the title
|
Changing to WIP pending #2741 |
| @@ -28,7 +29,11 @@ private object Frontend { | |||
| programName("php2cpg"), | |||
| opt[String]("php-ini") | |||
| .action((x, c) => c.copy(phpIni = Some(x))) | |||
| .text("php.ini path used by php-parser. Defaults to php.ini shipped with Joern.") | |||
| .text("php.ini path used by php-parser. Defaults to php.ini shipped with Joern."), | |||
| opt[Seq[String]]("exclude-overrides") | |||
There was a problem hiding this comment.
can we split this in two? I think from an end-user's perspective they either want to disable the default exclusions or add additional exclusions, but rarely both at the same time.
| "<unknown>" | ||
| ).map(PathFilter.standardisePath) | ||
| } | ||
| } |
There was a problem hiding this comment.
with other frontends we've seen bugs with filtering for untested combinations of absolute and relative paths for a) the input path and b) the excluded path. Can you add some tests for here to ensure that works as intended in all cases?
|
Sorry, I did not see this PR. |
No worries! The extracted filtering is definitely the better way to go |
|
@max-leuthaeuser with @johannescoetzee on vacation, could you please refactor this PR to make use of #2741? Needed to fix #2703. Thank you! |
Never mind. Looks like the PR was reverted. |
johannescoetzee
force-pushed
the
johannes/php-dir-excludes
branch
from
03dc962
to
5ac6cbc
Compare
This introduces another way of filtering input files, so there's a TODO to go through the frontends and extract common functionality into x2cpg.