-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jimple] Remove jsp add html and json #4528
base: master
Are you sure you want to change the base?
Conversation
I would not consider jsp to be config files but code. Also added json and HTML files. The latter usually also does not contain configurations but i would expect it there (currently).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to also add entries for this under io.joern.x2cpg.passes.frontend.JavaConfigFileCreationPass
to have it working e2e
Besides the weirdly formatted Java code, JSP will usually contain HTML. At qwiet, we don't use jimple2cpg, but for javasrc2cpg and java2cpg we look at the HTML contained in |
For me it is ok to keep (or add?) the JSP to the config file node because we might loose (important) information otherwise. However, the point of JSP having HTML content is opening up a path where we potentially end up adding everything except |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Jimple this choice is fine I think, but remember to add .html
to the filters in io.joern.x2cpg.passes.frontend.JavaConfigFileCreationPass
otherwise this won't be picked up. Alternatively, one can add a config test similar to what is in Java.
I would not consider jsp to be config files but code. Also added json and HTML files. The latter usually also does not contain configurations but i would expect it there (currently).