-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added keyboard movement #63
Conversation
I think this makes sense scope-wise. Curious to hear anybody else's opinion as well... API-wise: I think simultaneous movement should be implemented and be the default. Perhaps even the only mode, and remove the mode field. If you don't want keyboard controls, you can set Curious for other thoughts on this as well. |
The implementation I went for seemed the most sane to me but I'm curious what u guys think.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, API-wise, I think this adds it in a way that fits well with the scope and the rest of this crate.
We should update the readme/crate docs, maybe examples and this is good to go :)
I added a bit of Documentation, but I'm not sure if its too wordy so I'll defer to @johanhelsing on that. Otherwise I'm fairly happy with the changes, hope u guys are as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply added constant keyboard movement to the
do_camera_movement
system andMoveMode
andDirectionKeys
fields toPanCam
and registered them in Bevy.As I do not know if this change is even desired, this seemed to be the least intrusive API/code change.
Further changes I thought about but discarded because of reason above:
do_camera_movement
into multiple systems.MoveMode
.Addresses #52