Feature: matchbox_server docker image GitHub action

[AgustinRamiroDiaz]

Part of #372

What

Adds this github action configured for this repo

Testing done

You can see the triggers of my tests

The pushed images are here

Configuration from your side

Requires creating an access token in Docker Hub, and configuring the secret DOCKERHUB_TOKEN and the variable DOCKERHUB_USER in this repo

[simbleau]

Wow, thanks for this!

[johanhelsing]

We are already building and pushing images to the github container registry and then manually pushing to dockerhub.

With this PR, we'd build the server image twice, though. Would be good if there was just one image built per version. Also not sure if continuing to push to ghcr.io is valuable or not.

Maybe we should just choose one container registry, and either drop docker or ghcr? Either way, getting rid of the manual steps would be great.

[AgustinRamiroDiaz]

@johanhelsing oh I haven't seen that before, it's under the code workflow.

I can do whatever you think it's best. We could merge the 2 workflows into the code one and keep building + pushing to both registries there, or if you plan on dropping support we can also move to the current implementation. Let me know so I update the PR :D

[johanhelsing]

Thanks, I think it's best to push to both registries, if not too complicated. I think the image should build on all pr runs, but only push on tags.

I think the push on tag path might be broken, perhaps the workflow is not triggering on tags anymore... at least I had to do it manually last release.

Thanks for working on this!

[AgustinRamiroDiaz]

I think the push on tag path might be broken, perhaps the workflow is not triggering on tags anymore... at least I had to do it manually last release.

@johanhelsing I think that was because tags were not taken into account in the workflow triggers. I'll fix that too in this PR

Thanks for working on this!

You're welcome :)

[johanhelsing]

I think at least some of these steps should have:

if: startsWith(github.ref, 'refs/tags/')