Highlight toggle flips states when graph is updated #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Been using this for a bit now, works pretty good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hovering over the description of a graph, its line and area get highlighted by adding a specific CSS classes to these elements in DOM. When the pointer leaves the description, these classes are removed from the DOM.
If a graph is highlighted while being updated with the latest data, the toggle flips. Now the line and area of a graph are highlighted when the pointer leaves the description.
Such thing is unlikely to happen when a graph refreshes in long periods of time, but can be a problem if the graph updates itself every five seconds or so.
This pull request takes this edge case into account. I also did some formatting.