Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(session): Add UnexpectedError(CmdError) variant #274

Merged
merged 1 commit into from
Oct 19, 2024
Merged

fix(session): Add UnexpectedError(CmdError) variant #274

merged 1 commit into from
Oct 19, 2024

Conversation

surajk-m
Copy link
Contributor

Closes #175

Added UnexpectedError(CmdError) variant to handle errors from the webdriver host that do not conform to the expected standard.

jonhoo
jonhoo approved these changes Oct 19, 2024
View reviewed changes
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@jonhoo jonhoo merged commit 1085553 into jonhoo:main Oct 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webdriver should not panic on invalid argument
2 participants
@surajk-m @jonhoo