-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add reconnection capability for persisted WebDriver sessions #276
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition, thank you! Just a few smaller bits to tidy up.
- Use `::new` in both session creation and reconnection paths - Modify and return the existing client instance directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking quite good now, really just nits left :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you!
Closes #57
The
with_existing_session
method introduces the ability to reconnect to an already established WebDriver session using itssession ID
. This enables reuse of an active session without having to create a new one, which is particularly beneficial in scenarios such as process restarts or unexpected disconnections.