Skip to content

Improve deprecation noitce for old wait_* methods #122

Improve deprecation noitce for old wait_* methods

Improve deprecation noitce for old wait_* methods #122

GitHub Actions / clippy succeeded Feb 17, 2024 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (3)

src/session.rs|749 col 70| warning: the borrowed expression implements the required traits
--> src/session.rs:749:70
|
749 | base64::engine::general_purpose::STANDARD.encode(&format!(
| _________________________________________________^
750 | | "{}:{}",
751 | | url.username(),
752 | | url.password().unwrap_or("")
753 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: #[warn(clippy::needless_borrows_for_generic_args)] on by default
help: change this to
|
749 ~ base64::engine::general_purpose::STANDARD.encode(format!(
750 + "{}:{}",
751 + url.username(),
752 + url.password().unwrap_or("")
753 ~ ))
|
src/session.rs|818 col 55| warning: deref which would be done by auto-deref
--> src/session.rs:818:55
|
818 | let body = match serde_json::from_str(&*body)? {
| ^^^^^^ help: try: &body
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: #[warn(clippy::explicit_auto_deref)] on by default
src/key.rs|212 col 9| warning: taken reference of right operand
--> src/key.rs:212:9
|
212 | String::new() + &self + rhs
| ^^^^^^^^^^^^^^^^-----
| |
| help: use the right value directly: self
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: #[warn(clippy::op_ref)] on by default