Skip to content

Commit

Permalink
[ci] Make sure CI fails if the tests fail
Browse files Browse the repository at this point in the history
Fix the tests, they have been broken since we require CMake >= 3.10
  • Loading branch information
gergondet committed Dec 6, 2023
1 parent 7602dd6 commit 6b33181
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: [ubuntu-22.04]

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v3

- name: Run project tests
run: |
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
hpp/idl/*.pyc
.docs/build
_unittests/build/
_unittests/install/
2 changes: 1 addition & 1 deletion _unittests/cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.2)
cmake_minimum_required(VERSION 3.10)

set(PROJECT_NAME jrl-cmakemodules-cpp)
set(PROJECT_VERSION 0.0.0)
Expand Down
2 changes: 1 addition & 1 deletion _unittests/dependency/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.2)
cmake_minimum_required(VERSION 3.10)

set(PROJECT_NAME jrl-cmakemodules-dependency)
set(PROJECT_VERSION 0.0.0)
Expand Down
2 changes: 1 addition & 1 deletion _unittests/python/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.1)
cmake_minimum_required(VERSION 3.10)

# These variables have to be defined before running SETUP_PROJECT
set(PROJECT_NAME jrl-cmakemodules-python)
Expand Down
3 changes: 3 additions & 0 deletions _unittests/run_unit_tests.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#!/bin/bash

set -e
set -x

unittests="python cpp dependency catkin"

# Code for running a specific unit test
Expand Down

0 comments on commit 6b33181

Please sign in to comment.