Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with CMP0167 - FindBoost module has been removed #728

Open
ManifoldFR opened this issue Dec 3, 2024 · 1 comment
Open

Deal with CMP0167 - FindBoost module has been removed #728

ManifoldFR opened this issue Dec 3, 2024 · 1 comment

Comments

@ManifoldFR
Copy link
Contributor

ManifoldFR commented Dec 3, 2024

In the CMake docs: https://cmake.org/cmake/help/latest/policy/CMP0167.html.

The TLDR is that CMake no longer provides the FindBoost.cmake module (which we vendor ourselves), and just delegates to the Boost libraries' included BoostConfig.cmake - which are provided starting Boost 1.70.
Calls to find_package(Boost) now need to be find_package(Boost CONFIG).

  • We could remove the FindBoost.cmake copy we include with jrl-cmakemodules, I think. It contains the old logic for finding Boost, and Boost itself now provides its own find module.
  • We need to either set the policy for old-style calls to find_package(Boost) to function, or fix the add_project_dependency calls that find Boost in our downstream projects (of the top of my head: eigenpy, pinocchio).
@ManifoldFR ManifoldFR changed the title Deal with CMP0167 - **FindBoost** module has been removed Deal with CMP0167 - FindBoost module has been removed Dec 3, 2024
@ManifoldFR
Copy link
Contributor Author

I remember you did something on aligator related to this a few weeks back @jorisv ?

ManifoldFR added a commit to edantec/simple-mpc that referenced this issue Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant