Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: remove distutils use, fix #623 #624

Merged
merged 1 commit into from
Oct 9, 2023
Merged

python: remove distutils use, fix #623 #624

merged 1 commit into from
Oct 9, 2023

Conversation

nim65s
Copy link
Collaborator

@nim65s nim65s commented Oct 4, 2023

Hi,

This allow compatibility with python 3.12, remove warnings on python 3.10 & 3.11, but break compatibility with python < 3.4 (for pathlib)

NB: I guess this would require multilple tests in different setups to check that this is not breaking anything.

@nim65s
Copy link
Collaborator Author

nim65s commented Oct 4, 2023

Also I didn't change anything in the cython/ directory.
@gergondet : tell me if you prefer me to handle this in this PR, or if we should do otherwise.

@jcarpent jcarpent merged commit 6c9c3a4 into master Oct 9, 2023
2 checks passed
@nim65s nim65s deleted the py312 branch October 9, 2023 13:42
nim65s added a commit that referenced this pull request Oct 30, 2023
It was removed in #624, but ROS-CI still needs it.
nim65s added a commit that referenced this pull request Oct 30, 2023
It was removed in #624, but ROS-CI still needs it.
nim65s added a commit that referenced this pull request Oct 31, 2023
It was removed in #624, but ROS-CI still needs it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants