Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: update CHANGELOG.md #633

Merged
merged 2 commits into from
Nov 14, 2023
Merged

release: update CHANGELOG.md #633

merged 2 commits into from
Nov 14, 2023

Conversation

nim65s
Copy link
Collaborator

@nim65s nim65s commented Nov 10, 2023

Hi,

Eigenpy recently adopted a changelog style based on https://keepachangelog.com/.

Therefore, on each release, a few lines should be added / updated in this file, so I guess the right place to do so is in the release target, along with other similar file updates, like package.xml & pyproject.toml.

Here is a simple implementation in sed.

It would be problematic in projects:

  1. using the jrl-cmakemodule
  2. having a CHANGELOG.md
  3. not following keepachangelog.com
  4. with lines matching the regex \#\# \\[Unreleased\\] and/or ^\\[Unreleased]: \\(https://.*compare/\\)\\(v.*\\)...HEAD

But I guess there those conditions are never met.

@jorisv : maybe you would like to test this on your side ?

@gergondet gergondet mentioned this pull request Nov 13, 2023
@nim65s nim65s merged commit 5709150 into master Nov 14, 2023
3 checks passed
@nim65s nim65s deleted the changelog branch November 14, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants