Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADD_PYTHON_MEMORYCHECK_UNIT_TEST macro #638

Merged
merged 6 commits into from
Nov 24, 2023

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Nov 20, 2023

ADD_PYTHON_MEMORYCHECK_UNIT_TEST macro run Python unit tests through valgrind to detect memory leaks.

@jorisv jorisv self-assigned this Nov 20, 2023
@jorisv jorisv requested a review from nim65s November 20, 2023 16:27
@jorisv jorisv marked this pull request as ready for review November 20, 2023 16:27
@jorisv jorisv force-pushed the topic/memory_check_unit_test branch from d1e7e9c to d670a4e Compare November 22, 2023 10:09
test.cmake Show resolved Hide resolved
Copy link
Collaborator

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure ARGN processing is perfect, but it looks like this is working well enough in my test cases. Thanks !

@jorisv jorisv force-pushed the topic/memory_check_unit_test branch from 936d078 to 54a8359 Compare November 24, 2023 08:57
@jorisv jorisv merged commit 02719f3 into jrl-umi3218:master Nov 24, 2023
2 checks passed
@jorisv jorisv deleted the topic/memory_check_unit_test branch July 23, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants