CMakeLists.txt: dont include base #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This follow #670, and fix the case where this project is used with
FetchContent, becauseFetchContentwould detect the newCMakeLists.txtand execute it.Then, if this
CMakeLists.txtincludesbase.cmake, multiple global targets are created in theFetchContentand an error is raised later, in the downstreamproject()initialization, as its own include ofbase.cmakewould try to define again the same global targets.Of course, the proper fix would be to gracefully allow multiple inclusions of
base.cmake, but that's a lot of work.Instead, this PR only get what's need to generate CMake export in CMakeLists.txt.