Add package.xml #694
Merged
Add package.xml #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nim65s
approved these changes
May 13, 2024
There was a problem hiding this comment.
This maintainer list is mostly used by ROS buildfarm, so as long as we don't publish this inside https://github.com/ros/rosdistro/ this list shouldn't hurt anyone.
Still, yes, it could be good to define a proper list of authors / maintainers in this package in general.
jcarpent
approved these changes
May 21, 2024
Co-authored-by: Guilhem Saurel <[email protected]>
MaximilienNaveau
force-pushed
the
topic/mnaveau/add-package-xml
branch
from
817131f to
08d1f0e
Compare
|
ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a package.xml file so one can use this package as a dependency directly.
I added a list of maintainer in this file.
It's hard to decide in practice as this project has many maintainers and contributors.
So I picked 3 names among the most commiters according to github...
If it's not politically correct tell me I could: