Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): update version + lockfile and ensure correctness in ci #85

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

mrcjkb
Copy link
Contributor

@mrcjkb mrcjkb commented Mar 1, 2024

Hey 👋

I noticed your last release and wanted to package it for nixpkgs.
It looks like you forgot to update the version in Cargo.toml + Cargo.lock again.

This PR adds some safety, as discussed in #67, by:

  • Extracting the version from the git tag and storing it in the VERSION environment variable.
  • Checking that it is set correctly in Cargo.toml (we have to remove the v prefix - will fail if not).
  • Ensure the lockfile is up to date (will fail if not).

I've also bumped the version in Cargo.toml to 0.4.3 and updated the lockfile.
Would you be open to pushing a 0.4.3 tag, so I can package this for nixpkgs?

@jrmoulton jrmoulton merged commit 52cf618 into jrmoulton:main Mar 2, 2024
6 of 7 checks passed
@jrmoulton
Copy link
Owner

Thanks. Haha I thought I had it right this time.

I'll push a 0.4.3 tag

@mrcjkb mrcjkb deleted the fix-cargo-lock branch March 3, 2024 04:45
@mrcjkb
Copy link
Contributor Author

mrcjkb commented Mar 3, 2024

🤔 looks like it broke something?

@junglerobba
Copy link
Contributor

junglerobba commented Mar 3, 2024

The nix build workflow should already fail if there is a mismatch, not sure we also need to fail the release for this.

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Mar 3, 2024

The nix build workflow should already fail if there is a mismatch, not sure we also need to fail the release for this.

It should fail if the lock file is out of date, but it won't fail if the version in Cargo.toml doesn't match the release tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants