Add tests #87
Merged
Add tests #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step to making this crate more testable. In order to test this crate, we need to be able to execute tmux commands against a tmux socket that is not the one we are currently in. Currently, `execute_tmux_command` is used to interact with tmux, and this makes it difficult to test because you would have to manually add `-L test-socket` to each invocation of that method. By creating a tmux struct and storing the socket name in there, it becomes possible to test.
create a lib.rs so that we can access modules from the unit tests as well as the main.rs
|
Ahh yeah this will be nice. Much improved. I'll also work on adding some tests. When I start working on them I'll open a tracking issue and say which tests I'm working on. These look like really great changes to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the foundation for testing
tms. It does a few things:execute_tmux_commandfunction, and instead creates aTmuxstruct, whose methods expose an API for tmux commands. This allows us to control which tmux socket is being used, and this in turn opens up the possibility of testingtmson a non-default tmux socket. As a side benefit, it cleans up the codebase a bit and eliminates a lot offormat!based string interpolation that was needed to useexecute_tmux_command.testsdirectory and use structs and functions from the crate, as I do when testing thetms configcommand. I pretty much just took everything that wasn'tfn maininmain.rsand stuck it inlib.rs.There are still a few more tests I wanted to write, but my branch was drifting from main, and since there are two tests here, I thought it made sense to make a PR.
cc @jrmoulton @junglerobba