Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am building my portfolio and using your personal-portfolio repo to get some inspiration. As I am going through the code right now, I discovered some typos in the code because of which it was not functioning the way I wanted to.
As I am using Prettier on VS code, it shows as a lot of changes have been made. Please ignore those. By far, I have made two main changes, which is, fixing the typos. I will explain them below.
Fixed className
File: Banner.js
Line: 57
Change:
<Row className="aligh-items-center">
changed to<Row className="align-items-center">
Result: Could align the content to the center
Fixed 'projects' from NavBar
File: NavBar.js
Line: 63
Change:
<Nav.Link href="#projects" className={activeLink === 'projects' ? 'active navbar-link' : 'navbar-link'} onClick={() => onUpdateActiveLink('projects')}>Projects</Nav.Link>
changed to<Nav.Link href="#project" className={ activeLink === "projects" ? "active navbar-link" : "navbar-link" } onClick={() => onUpdateActiveLink("projects")} > Projects </Nav.Link>
Result: Previously clicking on the "Projects" tab would not take me to the projects section, while "Home", "Skills" and "Let's connect" did. Changing
href="#projects"
tohref="#project"
fixed this issue.So far I have encountered these two issues. Hope this helped and thank you.