allow ignore missing references from source #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StaticLint tends to give too many false missing references, and that makes this - otherwise very useful - feature barely usable, as one tends to ignore them, or turn this feature off.
On the other hand, I still have incorrectly tagged missing references reported 2.5 years ago, and new ones keep popping up. So the obvious solution of waiting for all of them getting fixed seems not to be viable.
The changes in this pull request allow ignoring specific missing reference warnings, via special comment lines added to any source. These lines should start with the text "#@linter_refs", and then provide comma-separated list(s) of the missing references to ignore.
Controlling the linter through #pragma statements is common practice. This functionality was also present in Lint.jl through a @lintpragma macro.