-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bunch of fixes from production usage #4 #35
A bunch of fixes from production usage #4 #35
Conversation
long requires special lock on x86, and slower in general. Profiler shows a lot of time in Disposed checks.
…treams with 1000000 * N frames known
a179737
to
6685f4d
Compare
Hard to debug issues when no stacktrace.
6685f4d
to
945933f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I will be away from keyboard for a few hours but when I return I will confirm changes and merge.
Thanks again for your contributions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes LGTM!
Testing confirms everything is still working!!
Thank you for your contribution!!!
Thanks again for your contributions! The only thing I notice is that since we no longer run the old tests its possible something could sneak up during refactoring I will probably get started moving most of the tests to a proper unit tests solution in due course so the unit tests can be run in the pipeline as part of build. Thank you for your contributions! |
Interlocked
API andint
to speedup on old x86 32 bit architecture.