Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of fixes from production usage #4 #35

Merged
merged 10 commits into from
Dec 17, 2023

Conversation

dimhotepus
Copy link
Contributor

@dimhotepus dimhotepus commented Dec 16, 2023

  • Allow to configure RTSP client inactivity timeouts for server streams.
  • Use .net core way to enable unicast port reuse for socket.
  • Thread-safe access to state shared between server and maintaining threads.
  • Disposable uses Interlocked API and int to speedup on old x86 32 bit architecture.
  • Do not busy wait for 100 cycles during waiting for events. It is too long and consumes CPU time.
  • Speedup thread-safe empty queue checks.
  • Do not wait for events in queue for 1 microsecond. There are no streams with 1000000 * N FPS and such small wait time creates unneeded CPU load. Allow to configure how much time to wait and use 1 millisecond as default.
  • Do not lose exception stack traces in logs. Hard to debug issues when no stack traces.

Hard to debug issues when no stacktrace.
Copy link
Owner

@juliusfriedman juliusfriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I will be away from keyboard for a few hours but when I return I will confirm changes and merge.

Thanks again for your contributions!

Copy link
Owner

@juliusfriedman juliusfriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes LGTM!

Testing confirms everything is still working!!

Thank you for your contribution!!!

@juliusfriedman juliusfriedman merged commit dd5e552 into juliusfriedman:master Dec 17, 2023
3 checks passed
@juliusfriedman
Copy link
Owner

Thanks again for your contributions!

The only thing I notice is that since we no longer run the old tests its possible something could sneak up during refactoring

I will probably get started moving most of the tests to a proper unit tests solution in due course so the unit tests can be run in the pipeline as part of build.

Thank you for your contributions!

@dimhotepus dimhotepus deleted the production-feedback-1 branch December 17, 2023 19:28
@dimhotepus dimhotepus changed the title A bunch of fixes from production usage A bunch of fixes from production usage #4 Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants