Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Allow BinderHub to work with an existing JupyterHub #1862

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

manics
Copy link
Member

@manics manics commented Jun 28, 2024

I thought this used to be possible, but it might be my imagination.

https://discourse.jupyter.org/t/installing-binderhub-to-existing-jupyterhub/26561

@yuvipanda
Copy link
Collaborator

I was just talking to @minrk about this this moning! What I'd like to propose is that we make https://github.com/2i2c-org/binderhub-service/ the official chart for binderhub (merge that repo into this repo), and deprecate the existing chart. This keeps the clean split between binderhub and jupyterhub, and allows the binderhub setup to be used with alternative frontends more easily as well (like https://github.com/yuvipanda/jupyterhub-fancy-profiles).

We (2i2c) have now been able to deploy many mybinder.org style binderhubs with that chart now (with docs at https://infrastructure.2i2c.org/howto/features/binderhub-ui/).

The plan as I had talked about with @minrk is to first migrate https://github.com/jupyterhub/mybinder.org-deploy to use binderhub-service, to iron out any issues that may exist. And then merge that in here afterwards. I'd also like 2i2c-org/binderhub-service#57 to be implemented before that.

What do you think of that, @manics?

@manics
Copy link
Member Author

manics commented Jun 29, 2024

@yuvipanda Sounds good to me! Do you mind opening a new issue in this repo, then we can close this and direct people there. We can also use the issue to discuss the layout of this repo, e.g. should the chart remain part of this repo or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants