-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add support for extending file storage to other schemes and provide a runtime flag for the same #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan-rao
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
C-refactor
Category: Refactor
labels
Jan 14, 2024
… provide a runtime flag for the same
…nto runtime-flag-for-s3
Chethan-rao
force-pushed
the
runtime-flag-for-s3
branch
from
January 14, 2024 14:53
03ec872
to
ca5e108
Compare
Chethan-rao
force-pushed
the
runtime-flag-for-s3
branch
from
January 18, 2024 10:18
3ca460f
to
e5d5905
Compare
Chethan-rao
force-pushed
the
runtime-flag-for-s3
branch
from
January 18, 2024 13:49
94839bf
to
dacf4be
Compare
…nto runtime-flag-for-s3
SanchithHegde
previously approved these changes
Jan 24, 2024
SanchithHegde
previously approved these changes
Jan 28, 2024
SanchithHegde
previously approved these changes
Jan 29, 2024
SanchithHegde
approved these changes
Jan 29, 2024
jarnura
approved these changes
Jan 29, 2024
sai-harsha-vardhan
approved these changes
Jan 30, 2024
pixincreate
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR includes refactoring for:
Additional Changes
Motivation and Context
Closes #3338, Closes #3347
How did you test it?
dispute_id
File System
Aws S3
Checklist
cargo +nightly fmt --all
cargo clippy