refactor(core): add locker config to enable or disable locker #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aprabhat19
added
A-core
vspecky
requested changes
Jan 16, 2024
Aprabhat19
changed the title
2 tasks
…rswitch into locker-enable-config
vspecky
requested changes
Jan 16, 2024
| pub card_issuer: Option<String>, | ||
| pub card_network: Option<api_enums::CardNetwork>, | ||
| pub card_type: Option<String>, | ||
| pub save_to_locker: bool, |
There was a problem hiding this comment.
Suggested change
| pub save_to_locker: bool, | |
| pub saved_to_locker: bool, |
vspecky
previously approved these changes
Jan 16, 2024
vspecky
previously approved these changes
Jan 17, 2024
kashif-m
reviewed
Jan 17, 2024
kashif-m
previously approved these changes
Jan 17, 2024
2 tasks
vspecky
approved these changes
Jan 18, 2024
Narayanbhat166
approved these changes
Jan 18, 2024
pixincreate
added a commit
that referenced
this pull request
Jan 18, 2024
* 'main' of github.com:juspay/hyperswitch: feat(users): Added get role from jwt api (#3385) feat(users): Add `preferred_merchant_id` column and update user details API (#3373) chore(version): 2024.01.18.1 refactor(core): add locker config to enable or disable locker (#3352) fix(connector): [Cashtocode] update amount from i64 to f64 in webhook payload (#3382) fix(metrics): Add TASKS_ADDED_COUNT and TASKS_RESET_COUNT metrics in router scheduler flow (#3189) fix(connector): Trustpay zen error mapping (#3255) fix(user): fetch profile_id for sample data (#3358) refactor(connector): [Volt] Refactor Payments and Refunds Webhooks (#3377) chore(version): 2024.01.18.0
SanchithHegde
added
C-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add locker config to enable or disable locker , so that if the locker is enabled we can store the card_details in the locker else if the config is disabled we don't
Also this PR involvesaddition in the
MandateResponse.Additional Changes
Motivation and Context
This Feature provides an option for the merchant whether or not to save the card at hyperswitch . Saving the card at hyperswitch is not necessary if the mandate is created at the processor level.
How did you test it?
Create an MA & MCA
Disable the
locker_enabledconfiglocker_enabledconfig-When we do a list mandates we have an additional field
payment_method_typeChecklist
cargo +nightly fmt --allcargo clippy