-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(users): Add preferred_merchant_id
column and update user details API
#3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMani
added
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-users
Area: Users
labels
Jan 17, 2024
ThisIsMani
changed the title
feat(users): Add preferred merchant id column and update user details API
feat(users): Add Jan 17, 2024
preferred_merchant_id
column and update user details API
apoorvdixit88
previously approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
racnan
previously approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing other than that LGTM.
racnan
approved these changes
Jan 18, 2024
lsampras
approved these changes
Jan 18, 2024
ivor11
approved these changes
Jan 18, 2024
pixincreate
added a commit
that referenced
this pull request
Jan 18, 2024
* 'main' of github.com:juspay/hyperswitch: feat(users): Added get role from jwt api (#3385) feat(users): Add `preferred_merchant_id` column and update user details API (#3373) chore(version): 2024.01.18.1 refactor(core): add locker config to enable or disable locker (#3352) fix(connector): [Cashtocode] update amount from i64 to f64 in webhook payload (#3382) fix(metrics): Add TASKS_ADDED_COUNT and TASKS_RESET_COUNT metrics in router scheduler flow (#3189) fix(connector): Trustpay zen error mapping (#3255) fix(user): fetch profile_id for sample data (#3358) refactor(connector): [Volt] Refactor Payments and Refunds Webhooks (#3377) chore(version): 2024.01.18.0
Gnanasundari24
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jan 19, 2024
Gnanasundari24
removed
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jan 19, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
preferred_merchant_id
.preferred_merchant_id
will be used at the time of signin to directly use thatmerchant_id
when user has access to multiple merchant accounts.Additional Changes
Motivation and Context
To support the highlighted flow in the following diagram.
Note: This PR doesn't have the actual changes of the flow, but has few required changes to make the highlighted flow possible.
How did you test it?
Postman.
If the api is successful, the db will be updated and the response will be 200 OK.
Checklist
cargo +nightly fmt --all
cargo clippy