Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(analytics): adding status code to connector Kafka events #3393

Merged
merged 7 commits into from
Jan 30, 2024
Merged

chore(analytics): adding status code to connector Kafka events #3393

merged 7 commits into from
Jan 30, 2024

Conversation

harsh-sharma-juspay
Copy link
Contributor

@harsh-sharma-juspay harsh-sharma-juspay commented Jan 18, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

adding status code to connector Kafka events

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

f
do payment confirm call and then check for the status_code in log in loki where topic=hyperswitch-outgoing-connector-events

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@harsh-sharma-juspay harsh-sharma-juspay self-assigned this Jan 18, 2024
@harsh-sharma-juspay harsh-sharma-juspay linked an issue Jan 18, 2024 that may be closed by this pull request
bug(EVENT_VIEWER): connector events is missing a status code field #3394
Closed
@harsh-sharma-juspay
Copy link
Contributor Author

Screenshot 2024-01-18 at 11 29 49 PM

@harsh-sharma-juspay
Copy link
Contributor Author

Screenshot 2024-01-18 at 11 32 07 PM

lsampras
lsampras previously approved these changes Jan 19, 2024
View reviewed changes
crates/router/src/services/api.rs Outdated Show resolved Hide resolved
ivor11
ivor11 previously approved these changes Jan 19, 2024
View reviewed changes
@lsampras lsampras dismissed stale reviews from ivor11 and themself via f4ee4ed January 22, 2024 09:02
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit d6807ab Jan 30, 2024
10 of 12 checks passed
@likhinbopanna likhinbopanna deleted the add_status_code_connector_events branch January 30, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivor11 ivor11 ivor11 approved these changes

@sagarnaikjuspay sagarnaikjuspay sagarnaikjuspay approved these changes

@lsampras lsampras lsampras approved these changes

@ShivanshMathurJuspay ShivanshMathurJuspay Awaiting requested review from ShivanshMathurJuspay

Assignees

@harsh-sharma-juspay harsh-sharma-juspay

Labels
A-Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(EVENT_VIEWER): connector events is missing a status code field
5 participants
@harsh-sharma-juspay @lsampras @sagarnaikjuspay @ivor11 @likhinbopanna