feat: Soft kill kv #4582
Merged
feat: Soft kill kv #4582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 8, 2024 13:25
dracarys18
requested changes
May 13, 2024
crates/router/src/db/customers.rs
Outdated
Comment on lines
212
to
215
| let key = PartitionKey::MerchantIdCustomerId { | ||
| merchant_id: merchant_id.as_str(), | ||
| customer_id: customer_id.as_str(), | ||
| }; |
There was a problem hiding this comment.
Same here redundant partition key
crates/storage_impl/src/errors.rs
Outdated
| @@ -143,6 +143,9 @@ impl RedisErrorExt for error_stack::Report<RedisError> { | |||
| key: Some(key.to_string()), | |||
| }) | |||
| } | |||
| RedisError::KvSoftKillMode => { | |||
| self.change_context(DataStorageError::RedisOperationDisabled) | |||
There was a problem hiding this comment.
Why are we converting into this error here?
There was a problem hiding this comment.
will remove this, was added for another approach
akshay-97
added
the
M-database-changes
dracarys18
previously approved these changes
May 15, 2024
jarnura
requested changes
May 16, 2024
dracarys18
previously approved these changes
May 16, 2024
inventvenkat
previously approved these changes
May 17, 2024
jarnura
approved these changes
May 17, 2024
dracarys18
approved these changes
May 17, 2024
SanchithHegde
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
We needed a way to gracefully disable kv with ongoing traffic in our services, Introducing soft kill mode(env switch) that when enabled will direct new inserts to db and updates of data present in kv to go to kv and other wise db
Additional Changes
Motivation and Context
We needed a way to gracefully disable kv with ongoing traffic in our services, Introducing soft kill mode(env switch) that when enabled will direct new inserts to db and updates of data present in kv to go to kv and other wise db
https://docs.google.com/document/d/1AvIID-rPRpQ7xy_VgUAeDWSkG0tdbY3xiz5OzBopTdw
How did you test it?
Do transactions in kv mode, run app in soft kill mode and check if existing payments in kv go through kv and new ones are in db
when in soft kill, storage scheme decided output log
[decide_storage_scheme] output: postgres_only for entity diesel_models::payment_intent::PaymentIntentduring soft kill mode, no merchant can be enabled for kv flow
{ "error": { "type": "invalid_request", "message": "Kv cannot be enabled when application is in soft_kill_mode", "code": "IR_06" } }Checklist
cargo +nightly fmt --allcargo clippy