Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(euclid): remove business_profile routing feature flag #5431

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix(euclid): remove business_profile routing feature flag #5431

merged 1 commit into from
Jul 24, 2024

Conversation

prajjwalkumar17
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 commented Jul 24, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Removes the redundant business_profile_routing feature flag from Payment method list.
#5430

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

We can run Cypress test cases for this.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner July 24, 2024 10:41
@prajjwalkumar17 prajjwalkumar17 marked this pull request as draft July 24, 2024 10:41
@prajjwalkumar17 prajjwalkumar17 linked an issue Jul 24, 2024 that may be closed by this pull request
[Refactor] Remove backwards compatibility of the routing crate #5345
Open
2 tasks
@prajjwalkumar17 prajjwalkumar17 marked this pull request as ready for review July 24, 2024 11:13
@likhinbopanna likhinbopanna merged commit bd0f66c into hotfix-2024.07.19.0 Jul 24, 2024
30 of 32 checks passed
@likhinbopanna likhinbopanna deleted the fix/pml_1 branch July 24, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

@Aprabhat19 Aprabhat19 Aprabhat19 approved these changes

@vspecky vspecky Awaiting requested review from vspecky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] Remove backwards compatibility of the routing crate
4 participants
@prajjwalkumar17 @Aprabhat19 @ShankarSinghC @likhinbopanna