Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable payment and refund filter at DB query level #5839

Merged

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Sep 9, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This is the hotfix PR for #5827

Currently payment and refund profile_id filter is applied at application level instead if DB level. This change implements filter at DB level instead of Application level.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@hrithikesh026 hrithikesh026 self-assigned this Sep 9, 2024
@hrithikesh026 hrithikesh026 requested review from a team as code owners September 9, 2024 08:24
Copy link

semanticdiff-com bot commented Sep 9, 2024

Review changes with SemanticDiff.

Analyzed 13 of 14 files.

Overall, the semantic diff is 9% smaller than the GitHub diff.

Filename Status
✔️ crates/storage_impl/src/payments/payment_attempt.rs Analyzed
✔️ crates/storage_impl/src/payments/payment_intent.rs Analyzed
✔️ crates/storage_impl/src/mock_db/payment_attempt.rs Analyzed
✔️ crates/router/src/types/storage/refund.rs 19.08% smaller
✔️ crates/router/src/db/kafka_store.rs Analyzed
✔️ crates/router/src/db/refund.rs 20.56% smaller
✔️ crates/router/src/core/payments.rs 15.85% smaller
✔️ crates/router/src/core/refunds.rs 30.65% smaller
✔️ crates/router/src/core/payments/helpers.rs 77.89% smaller
✔️ crates/hyperswitch_domain_models/src/lib.rs Analyzed
crates/hyperswitch_domain_models/src/refunds.rs Unsupported file format
✔️ crates/hyperswitch_domain_models/src/payments/payment_attempt.rs Analyzed
✔️ crates/hyperswitch_domain_models/src/payments/payment_intent.rs 1.97% smaller
✔️ crates/diesel_models/src/query/payment_attempt.rs Analyzed

@hrithikesh026 hrithikesh026 added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 9, 2024
@Gnanasundari24 Gnanasundari24 merged commit b75e864 into hotfix-2024.09.06.0 Sep 9, 2024
19 of 20 checks passed
@Gnanasundari24 Gnanasundari24 deleted the enable-filter-at-db-query-level branch September 9, 2024 11:04
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants