Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Connectors enum dependency from ConnectorIntegrationV2 trait #5856

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Sep 11, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Main branch PR #5840

Currently few functions in ConnectorIntegrationV2 trait accepts enum Connectors as argument. This prevents the trait from being used outside the repository (through connector_integration module).

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checked if the code compiled successfully.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@hrithikesh026 hrithikesh026 self-assigned this Sep 11, 2024
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner September 11, 2024 10:07
Copy link

semanticdiff-com bot commented Sep 11, 2024

Review changes with SemanticDiff.

Analyzed 1 of 2 files.

Overall, the semantic diff is 38% smaller than the GitHub diff.

Filename Status
crates/router/src/services/connector_integration_interface.rs Unsupported file format
✔️ crates/hyperswitch_interfaces/src/connector_integration_v2.rs 37.76% smaller

@hrithikesh026 hrithikesh026 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 11, 2024
@Gnanasundari24 Gnanasundari24 merged commit 5e88185 into hotfix-2024.08.02.0 Sep 12, 2024
19 of 20 checks passed
@Gnanasundari24 Gnanasundari24 deleted the remove-connectors-enum-dependency-from-connector-integration-v2-hotfix branch September 12, 2024 11:29
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants