Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): return collect_billing_details_from_wallet_connector if always_collect_billing_details_from_wallet_connector is false in merchant payment method list #5857

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

ShankarSinghC
Copy link
Contributor

@ShankarSinghC ShankarSinghC commented Sep 11, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  1. collect_billing_details_from_wallets field should be made true if either of always_collect_billing_details_from_wallet_connector collect_billing_details_from_wallet_connector
  2. collect_shipping_details_from_wallets field should be made true if either of always_collect_shipping_details_from_wallet_connector collect_shipping_details_from_wallet_connector

So that the sdk gets to know that the address details needs to be collected from apple pay and not from the customers

Main branch pr #5854

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ShankarSinghC ShankarSinghC self-assigned this Sep 11, 2024
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner September 11, 2024 10:13
Copy link

semanticdiff-com bot commented Sep 11, 2024

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Overall, the semantic diff is 60% smaller than the GitHub diff.

Filename Status
✔️ crates/router/src/core/payment_methods/cards.rs 59.7% smaller

@ShankarSinghC ShankarSinghC linked an issue Sep 11, 2024 that may be closed by this pull request
@ShankarSinghC ShankarSinghC changed the title fix(router): fix merchant payment method list fix(router): return collect_billing_details_from_wallet_connector if always_collect_billing_details_from_wallet_connector is false in merchant payment method list Sep 12, 2024
@Gnanasundari24 Gnanasundari24 merged commit 32fd4ee into hotfix-2024.09.06.0 Sep 12, 2024
22 of 25 checks passed
@Gnanasundari24 Gnanasundari24 deleted the hotfix/fix-pml branch September 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix merchant payment method list
4 participants