Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: return optional request body from build_request_v2 in ConnectorIntegrationV2 trait #5878

Merged
merged 1 commit into from
Sep 13, 2024
Merged

refactor: return optional request body from build_request_v2 in ConnectorIntegrationV2 trait #5878

merged 1 commit into from
Sep 13, 2024

Conversation

hrithikesh026
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Main PR #5865
Currenlty fn get_request_body in ConnectorIntegrationV2 trait returns RequestContent type. Modified it to return Option.
This needs to be done since most flows with http get call don't need any RequestBody.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checked if code compiled successfully.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@hrithikesh026 hrithikesh026 self-assigned this Sep 13, 2024
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner September 13, 2024 06:02
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Sep 13, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Overall, the semantic diff is 3% smaller than the GitHub diff.

Filename Status
✔️ crates/hyperswitch_interfaces/src/connector_integration_v2.rs 3.09% smaller
✔️ crates/common_utils/src/request.rs Analyzed

@hrithikesh026 hrithikesh026 changed the title refactor: return optional request body from build_request_v2 in ConnectorIntegrationV2 refactor: return optional request body from build_request_v2 in ConnectorIntegrationV2 trait Sep 13, 2024
@hrithikesh026 hrithikesh026 mentioned this pull request Sep 13, 2024
Open
@hrithikesh026 hrithikesh026 linked an issue Sep 13, 2024 that may be closed by this pull request
return optional Request Body from fn get_request_body() #5866
Open
@hrithikesh026 hrithikesh026 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 13, 2024
@Gnanasundari24 Gnanasundari24 merged commit f476db8 into hotfix-2024.08.02.0 Sep 13, 2024
16 of 20 checks passed
@Gnanasundari24 Gnanasundari24 deleted the return-optional-body-from-build_request_v2_hotfix branch September 13, 2024 07:20
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahkal sahkal sahkal approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@hrithikesh026 hrithikesh026

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return optional Request Body from fn get_request_body()
5 participants
@hrithikesh026 @jarnura @sahkal @SanchithHegde @Gnanasundari24