Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [ZSL] compare consr_paid_amt with the total amount for identifying partial payments #5881

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

AkshayaFoiger
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

ZSL implements bank transfer payment, so the payment status is updated through webhooks.
Their webhook body has two fields for indicating the paid amount - paid_amt and consr_paid_amt we compared
paid_amt with total amount to identify the partial/over payments. But the field for what user paid is given in consr_paid_amt and what they will pay the merchant after fee is given in paid_amt.
In this Pr we are fixing this issue.

Hotfix for #5873

How did you test it?

As we cannot trigger the webhooks, we cannot test it in sandbox

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@AkshayaFoiger AkshayaFoiger requested a review from a team as a code owner September 13, 2024 09:57
Copy link

semanticdiff-com bot commented Sep 13, 2024

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Overall, the semantic diff is 45% smaller than the GitHub diff.

Filename Status
✔️ crates/router/src/connector/zsl/transformers.rs 44.84% smaller

@AkshayaFoiger AkshayaFoiger self-assigned this Sep 13, 2024
@AkshayaFoiger AkshayaFoiger added A-connector-compatibility Area: Connector compatibility A-connector-integration Area: Connector integration C-bug Category: Bug labels Sep 13, 2024
SamraatBansal
SamraatBansal previously approved these changes Sep 13, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Sep 13, 2024
@likhinbopanna likhinbopanna removed this pull request from the merge queue due to a manual request Sep 13, 2024
@AkshayaFoiger AkshayaFoiger changed the base branch from main to hotfix-2024.09.06.0 September 13, 2024 11:00
@AkshayaFoiger AkshayaFoiger dismissed stale reviews from SamraatBansal and deepanshu-iiitu September 13, 2024 11:00

The base branch was changed.

@likhinbopanna likhinbopanna merged commit c126ca3 into hotfix-2024.09.06.0 Sep 13, 2024
15 checks passed
@likhinbopanna likhinbopanna deleted the fix-amount-comp branch September 13, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-compatibility Area: Connector compatibility A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants