fix(connector): add config cleanup on payment connector deletion #5998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
@SanchithHegde Hi, is this PR going to get reviewed? The issue also didn't get labeled |
Aprabhat19
requested changes
Oct 1, 2024
|
@Aprabhat19 Hi again! Re-requested your review |
Aprabhat19
previously approved these changes
Oct 8, 2024
|
@SanchithHegde Hi sorry can we get a second reviewer? |
SanchithHegde
previously approved these changes
Nov 27, 2024
noagbmn
dismissed stale reviews from SanchithHegde and Aprabhat19
via
817dc6a
noagbmn
force-pushed
the
fix_delete_merchant_connector_account_from_config
branch
from
817dc6a
to
0c4b1bd
Compare
SanchithHegde
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fixes #5966 (in both v1 and v2). Now the router cleans up the configs table (or business_profile in v2) when a connector is deleted.
Additional Changes
Motivation and Context
How did you test it?
Added a payment and payout processor, checked if values are present in config, deleted and rechecked.
v1:
v2:
Checklist
cargo +nightly fmt --allcargo clippy