-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(users): Allow accepting invites for org_admin
s
#6253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMani
added
C-bug
Category: Bug
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-users
Area: Users
labels
Oct 7, 2024
Review changes with SemanticDiff. Analyzed 6 of 6 files. Overall, the semantic diff is 22% smaller than the GitHub diff.
|
apoorvdixit88
previously approved these changes
Oct 7, 2024
SanchithHegde
approved these changes
Oct 8, 2024
racnan
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets remove Entity
type from email and use one Entity
across repo.
apoorvdixit88
approved these changes
Oct 8, 2024
Riddhiagrawal001
approved these changes
Oct 8, 2024
likhinbopanna
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently accepting invites for org_admin will not work. This PR fixes it.
Additional Changes
Motivation and Context
Closes #6254
How did you test it?
Response:
Checklist
cargo +nightly fmt --all
cargo clippy