feat(connector): [Nexixpay] add mandates flow for cards #6259

mrudulvajpayee4935 · 2024-10-08T06:01:58Z

Type of Change

Description

Integrate mandates flow for card payments.
https://developer.nexi.it/en/funzionalita-/pagamenti-ricorrenti

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Cypress test:

1) Multiuse mandates

2) Singleuse mandates

3) Test cases in the headless mode

Note:

Skipping no3ds test cases as it is not supported by nexixpay
Remaining few test cases in headless mode is failing due to inconsistency in test environment from the connector - cc: @likhinbopanna @Gnanasundari24 **

Create Call

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_VyjzlxA4qJnZUAalRRpB8MGDRzw6moojPrhbHThoGwxrZiyCvNnuIdVKoWvumalE' \
--data '{
    "amount": 3545,
    "currency": "EUR",
    "confirm": false,
    "customer_id": "tester799",
    "setup_future_usage": "off_session"
}'

Confirm Call

curl --location 'http://localhost:8080/payments/pay_sFK1K3juhPteyDXgEH8X/confirm' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_VyjzlxA4qJnZUAalRRpB8MGDRzw6moojPrhbHThoGwxrZiyCvNnuIdVKoWvumalE' \
--data-raw '{
    "payment_method": "card",
    "return_url": "https://google.com",
    "payment_method_type": "credit",
    "payment_method_data": {
        "card": {
            "card_number": "4349940199004549",
            "card_exp_month": "12",
            "card_exp_year": "30",
            "card_holder_name": "Joseph Does",
            "card_cvc": "396"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "IT",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "[email protected]"
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "IT",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "[email protected]"
    },
    "customer_acceptance": {
        "acceptance_type": "offline"
    }
}'

MIT Call

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_VyjzlxA4qJnZUAalRRpB8MGDRzw6moojPrhbHThoGwxrZiyCvNnuIdVKoWvumalE' \
--data '{
    "amount": 3545,
    "currency": "EUR",
    "confirm": true,
    "customer_id": "tester799",
    "recurring_details": {
        "type": "payment_method_id",
        "data": "pm_WqDpelm1rZ4yvUkf579X"
    },
    "off_session": true
}'

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2024-10-08T06:02:01Z

Review changes with

Changed Files

File	Status
crates/hyperswitch_connectors/src/connectors/nexixpay/transformers.rs	39% smaller
crates/hyperswitch_connectors/src/connectors/nexixpay.rs	15% smaller
cypress-tests/cypress/e2e/PaymentUtils/Nexixpay.js	1% smaller
crates/hyperswitch_connectors/src/utils.rs	0% smaller
crates/router/src/configs/defaults/payment_connector_required_fields.rs	0% smaller

awasthi21 · 2024-11-08T07:19:07Z

crates/hyperswitch_connectors/src/connectors/nexixpay.rs

-            data: data.clone(),
-            http_code: res.status_code,
-        })
+        if data.request.connector_mandate_id().is_none() {


this check won't be needed if we use an enum for the PaymentsResponse
enum NexixpayResponse { PaymentsPresonse(NexixpayPaymentsResponse), MandateResponse(NexixpayMandateResponse), }
`

Take reference from Fiuu: Transformers

#[serde(untagged)] pub enum FiuuPaymentsResponse { PaymentResponse(Box<PaymentsResponse>), QRPaymentResponse(Box<DuitNowQrCodeResponse>), Error(FiuuErrorResponse), RecurringResponse(Vec<Box<FiuuRecurringResponse>>), }

srujanchikke

Please add cypress test cases as well.

srujanchikke · 2024-11-11T07:37:40Z

crates/hyperswitch_connectors/src/connectors/nexixpay.rs

        connectors: &Connectors,
    ) -> CustomResult<String, errors::ConnectorError> {
-        Ok(format!("{}/orders/3steps/init", self.base_url(connectors)))
+        if req.request.connector_mandate_id().is_none() {


can we check for off_session instead

tried this but it creates problem as normal payment and cit payment both use same endpoint.

srujanchikke · 2024-11-11T07:39:30Z

crates/hyperswitch_connectors/src/connectors/nexixpay/transformers.rs

+            name: item.router_data.get_billing_full_name()?,
+            street: item.router_data.get_billing_line1()?,
+            city: item.router_data.get_billing_city()?,
+            post_code: item.router_data.get_billing_zip()?,
+            country: item.router_data.get_billing_country()?,
+        };


All required fields should be added in payment_connector_required_fields.rs file

Its already added

srujanchikke · 2024-11-11T07:39:59Z

crates/hyperswitch_connectors/src/connectors/nexixpay/transformers.rs

+        let customer_info = CustomerInfo {
+            card_holder_name: item.router_data.get_billing_full_name()?,
+            billing_address: billing_address.clone(),
+            shipping_address: Some(billing_address),


why are we hardcoding shipping address to billing_address ?

mrudulvajpayee4935 · 2024-11-12T16:07:58Z

Please add cypress test cases as well.
Could not run cypress tests since we don't have support for 3ds mandates cypress tests. cc: @likhinbopanna

Gnanasundari24 · 2024-11-26T08:19:16Z

@mrudulvajpayee4935 Please run the cypress testcases for nexixpay

mrudulvajpayee4935 · 2024-11-26T09:15:10Z

have support for 3ds mandates cypress tests.

do we have support for 3ds mandates cypress tests? @Gnanasundari24

likhinbopanna · 2024-11-29T09:56:14Z