Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payments): populate payment_method_type in payment_attempt for cards #6557

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix(payments): populate payment_method_type in payment_attempt for cards #6557

merged 1 commit into from
Nov 13, 2024

Conversation

srujanchikke
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

hotfix PR for #6519

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@srujanchikke srujanchikke self-assigned this Nov 13, 2024
@srujanchikke srujanchikke requested a review from a team as a code owner November 13, 2024 11:57
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Nov 13, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/payments/operations/payment_confirm.rs  58% smaller
  crates/router/src/core/payments/operations/payment_create.rs  0% smaller
  crates/router/src/core/payments/transformers.rs  0% smaller

@srujanchikke srujanchikke linked an issue Nov 13, 2024 that may be closed by this pull request
[BUG] payment_method_type for cards is null #6512
Open
2 tasks
@srujanchikke srujanchikke force-pushed the 6512-payment_method_type_for_cards-hotfix branch from 9c984d8 to 596c49e Compare November 13, 2024 12:42
@srujanchikke srujanchikke reopened this Nov 13, 2024
@SanchithHegde SanchithHegde merged commit 6230eb4 into hotfix-2024.11.13.0 Nov 13, 2024
20 of 26 checks passed
@SanchithHegde SanchithHegde deleted the 6512-payment_method_type_for_cards-hotfix branch November 13, 2024 13:42
@srujanchikke srujanchikke added the A-core Area: Core flows label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

Assignees

@kashif-m kashif-m

@srujanchikke srujanchikke

Labels
A-core Area: Core flows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] payment_method_type for cards is null
4 participants
@srujanchikke @sai-harsha-vardhan @SanchithHegde @kashif-m