chore(analytics): SDK table schema changes #6579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
jagan-jaya
approved these changes
Dec 3, 2024
tsdk02
reviewed
Dec 3, 2024
| @@ -156,7 +157,7 @@ WHERE | |||
| length(_error) > 0; | |||
|
|
|||
| CREATE MATERIALIZED VIEW sdk_events_audit_mv TO sdk_events_audit ( | |||
| `payment_id` Nullable(String), | |||
| `payment_id` String, | |||
There was a problem hiding this comment.
The queue (sdk_events_queue) has payment_id as Nullable(String), is it fine to just have String in sdk_events_audit and sdk_events_audit_mv?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Updating SDK table schema
Additional Changes
crates/analytics/docs/clickhouse/scripts/sdk_events.sql
Motivation and Context
This resolves the issue people face for SDK Events table API on dashboard is using the sdk_events_audit table
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy