Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add payment_id as query param in merchant return url #6669

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

srujanchikke
Copy link
Contributor

@srujanchikke srujanchikke commented Nov 26, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

hotfix pr for #6665

Currently in payment link after redirection in case of non 3ds, we return to merchant url with following query params

  • payment id, status
    But for non 3ds we return to merchant url with following query params
  • status , client secret, manual_retry_allowed

Inorder to have consistency across all return response to merchant adding payment_id to 3ds/redirection like bank redirects response url.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Create 3ds transaction upon returning to merchant url redirection url should have payment id .

Screenshot 2024-11-26 at 6 37 03 PM

Create 3ds failure transaction it should have the payment id in the response
Screenshot 2024-11-26 at 6 41 52 PM

Create any other redirection payment method scenarios.- tested this locally with online banking fpx for fiuu.

{
    "amount": 1000,
    "currency": "MYR",
    "amount_to_capture": 1000,
    "confirm": false,
    "payment_link" : true,
    // "profile_id" : "{{profile_id}}",
    "capture_method": "automatic",
    "payment_method": "bank_redirect",
    "payment_method_type": "online_banking_fpx",
    "return_url": "https://google.com",
    "payment_method_data": {
        "bank_redirect": {
            "online_banking_fpx": {
                "issuer": "bank_islam"
            }
        }
    }
}
Screenshot 2024-11-26 at 6 44 05 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@srujanchikke srujanchikke self-assigned this Nov 26, 2024
@srujanchikke srujanchikke requested a review from a team as a code owner November 26, 2024 15:40
Copy link

semanticdiff-com bot commented Nov 26, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/payments/helpers.rs  0% smaller

@srujanchikke srujanchikke added the A-core Area: Core flows label Nov 26, 2024
@srujanchikke srujanchikke changed the title fix(core): add payment_id as query param in merchant return url (#6665) fix(core): add payment_id as query param in merchant return url Nov 26, 2024
@srujanchikke srujanchikke changed the title fix(core): add payment_id as query param in merchant return url fix(core): add payment_id as query param in merchant return url Nov 26, 2024
@srujanchikke srujanchikke added the C-bug Category: Bug label Nov 26, 2024
@likhinbopanna likhinbopanna merged commit 50cdb95 into hotfix-2024.11.25.0 Nov 27, 2024
25 of 33 checks passed
@likhinbopanna likhinbopanna deleted the hotfix_redirection_param branch November 27, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants