Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fill card_network for tokenization flow #6682

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sakilmostak
Copy link
Contributor

@Sakilmostak Sakilmostak commented Nov 27, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

In network tokenization flow, card network was missing because it is being fetched after cobadge check.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested through postman:

  • Enable the pg agnostic config
  • Make a CIT with setup_future_usage = off_session
  • or the same customer make a recurring payment with payment token

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sakilmostak Sakilmostak added A-core Area: Core flows C-bug Category: Bug labels Nov 27, 2024
@Sakilmostak Sakilmostak added this to the November 2024 Release milestone Nov 27, 2024
@Sakilmostak Sakilmostak self-assigned this Nov 27, 2024
@Sakilmostak Sakilmostak requested review from a team as code owners November 27, 2024 13:49
Copy link

semanticdiff-com bot commented Nov 27, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  config/deployments/production.toml Unsupported file format
  crates/router/src/core/payments/helpers.rs  0% smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants