refactor(core): add recurring customer support for nomupay payouts. #6687
+644
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperswitch-bot
bot
added
the
M-database-changes
sumanmaji4
changed the title
hyperswitch-bot
bot
added
the
M-api-contract-changes
sumanmaji4
force-pushed
the
core_changes_to_support_nomupay
branch
from
b098698
to
13f9582
Compare
hyperswitch-bot
bot
added
M-api-contract-changes
sumanmaji4
force-pushed
the
core_changes_to_support_nomupay
branch
from
a6d2247
to
dba2017
Compare
hyperswitch-bot
bot
added
M-api-contract-changes
kashif-m
reviewed
Dec 2, 2024
crates/api_models/src/payouts.rs
Outdated
| @@ -184,6 +184,8 @@ pub struct PayoutCreateRequest { | |||
| /// Customer's phone country code. _Deprecated: Use customer object instead._ | |||
| #[schema(deprecated, max_length = 255, example = "+1")] | |||
| pub phone_country_code: Option<String>, | |||
|
|
|||
| pub payment_method_id: Option<String>, | |||
There was a problem hiding this comment.
Suggested change
| pub payment_method_id: Option<String>, | |
| pub payout_method_id: Option<String>, |
crates/api_models/src/payouts.rs
Outdated
| @@ -568,6 +570,8 @@ pub struct PayoutCreateResponse { | |||
| #[remove_in(PayoutCreateResponse)] | |||
| #[schema(value_type = Option<String>, max_length = 1024, example = "Invalid card details")] | |||
| pub unified_message: Option<UnifiedMessage>, | |||
|
|
|||
| pub payment_method_id: Option<String>, | |||
There was a problem hiding this comment.
Suggested change
| pub payment_method_id: Option<String>, | |
| pub payout_method_id: Option<String>, |
crates/diesel_models/src/enums.rs
Outdated
Comment on lines
342
to
346
| pub enum TransactionFlow { | ||
| #[default] | ||
| Payment, | ||
| Payouts, | ||
| } |
There was a problem hiding this comment.
Suggested change
| pub enum TransactionFlow { | |
| #[default] | |
| Payment, | |
| Payouts, | |
| } | |
| pub enum PaymentDirection { | |
| #[default] | |
| Payin, | |
| Payout, | |
| } |
| _merchant_account: &domain::MerchantAccount, | ||
| _key_store: &domain::MerchantKeyStore, | ||
| ) -> RouterResult<()> { | ||
| todo!() | ||
| Ok(()) |
| use crate::{ | ||
| core::{ | ||
| errors::{self, RouterResult}, | ||
| // payment_methods::cards::get_pm_list_context, |
crates/router/src/core/payouts.rs
Outdated
| connector_data.merchant_connector_id.clone(), | ||
| ) { | ||
| let connector_mandate_details = HashMap::from([( | ||
| merchant_connector_id, // which connector was called [MCA] |
There was a problem hiding this comment.
Can we remove these comments?
crates/router/src/core/payouts.rs
Outdated
|
|
||
| let payment_method_id: Option<String> = payout_data | ||
| .payment_method | ||
| .as_ref() // Safely access the `payment_method` as a reference |
crates/router/src/core/payouts.rs
Outdated
Comment on lines
2138
to
2141
| #[cfg(all( | ||
| any(feature = "v1", feature = "v2"), | ||
| not(feature = "payment_methods_v2") | ||
| ))] |
There was a problem hiding this comment.
Why is this feature flag needed here? 🤔
crates/router/src/core/payouts.rs
Outdated
Comment on lines
2143
to
2156
| let payment_method = db | ||
| .find_payment_method( | ||
| &(state.into()), | ||
| key_store, | ||
| &payout_method_id, // need to get from api request | ||
| merchant_account.storage_scheme, | ||
| ) | ||
| .await | ||
| .change_context(errors::ApiErrorResponse::PaymentMethodNotFound) | ||
| .attach_printable("Unable to find payment method")?; | ||
|
|
||
| payout_data.payment_method = Some(payment_method.clone()); | ||
| payout_data.payouts.payout_method_id = | ||
| Some(payment_method.payment_method_id.clone()); |
| db.find_payment_method( | ||
| &(state.into()), | ||
| key_store, | ||
| &pm_id, // need to get from api request |
sumanmaji4
force-pushed
the
core_changes_to_support_nomupay
branch
from
403de74
to
9247d06
Compare
hyperswitch-bot
bot
removed
the
M-api-contract-changes
hyperswitch-bot
bot
added
the
M-api-contract-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
recurring customer support for nomupay
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy