Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): adyen - propagate connector mandate details in incoming webhooks #6720

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Dec 2, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Described in the linked #6719

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Ensures mandate details are stored for Adyen.

How did you test it?

Since this is an intermittent scenario, webhooks flow was tested locally by disabling propagation of mandate details during PSync flow for Adyen.

connector_mandate_details is populate post receiving the webhooks
Screenshot 2024-12-02 at 8 30 39 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m added the A-connector-integration Area: Connector integration label Dec 2, 2024
@kashif-m kashif-m self-assigned this Dec 2, 2024
@kashif-m kashif-m requested a review from a team as a code owner December 2, 2024 11:18
@kashif-m kashif-m linked an issue Dec 2, 2024 that may be closed by this pull request
2 tasks
Copy link

semanticdiff-com bot commented Dec 2, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector/adyen.rs  0% smaller
  crates/router/src/connector/adyen/transformers.rs  0% smaller

@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit bea4b9e Dec 2, 2024
19 of 21 checks passed
@likhinbopanna likhinbopanna deleted the 6719-bug-mandate-details-are-not-persisted-for-adyen-connector branch December 2, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] mandate details are not persisted for Adyen connector
4 participants