feat(connector): [Unifiedauthenticationservice] add Connector Template Code #6732
+1,357
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumanmaji4
changed the title
deepanshu-iiitu
requested changes
Dec 3, 2024
| @@ -243,6 +243,7 @@ default_imp_for_new_connector_integration_payment!( | |||
| connectors::Thunes, | |||
| connectors::Tsys, | |||
| connectors::Worldline, | |||
| connectors::Unifiedauthenticationservice, | |||
There was a problem hiding this comment.
Can we please maintain alphabetical order
sumanmaji4
force-pushed
the
add-uas-test
branch
from
ac89d3e
to
21426e5
Compare
deepanshu-iiitu
previously approved these changes
Dec 3, 2024
sahkal
previously approved these changes
Dec 3, 2024
config/config.example.toml
Outdated
| @@ -267,6 +267,7 @@ stripe.base_url_file_upload = "https://files.stripe.com/" | |||
| trustpay.base_url = "https://test-tpgw.trustpay.eu/" | |||
| trustpay.base_url_bank_redirects = "https://aapi.trustpay.eu/" | |||
| tsys.base_url = "https://stagegw.transnox.com/" | |||
| unifiedauthenticationservice.base_url = "https://uas.internal.staging.mum.juspay.net" | |||
There was a problem hiding this comment.
Can we have this as snake case please? Becomes difficult to read when the names get longer.
| @@ -123,6 +123,7 @@ pub enum Connector { | |||
| //Thunes, | |||
| Trustpay, | |||
| Tsys, | |||
| // Unifiedauthenticationservice, | |||
There was a problem hiding this comment.
Can we have this as UnifiedAuthenticationService so that the snake_case value used would be unified_authentication_service?
There was a problem hiding this comment.
Yes, @sumanmaji4 can you make this change!
sumanmaji4
dismissed stale reviews from sahkal and deepanshu-iiitu
via
88347bd
sumanmaji4
force-pushed
the
add-uas-test
branch
from
21426e5
to
88347bd
Compare
sahkal
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
template for unified_authentication_service
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy