Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain synchronicity of resolvers #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wmertens
Copy link

Introspection queries should always resolve synchronously, and this wrapper causes them to be async. This causes problems when used in conjunction with Apollo.

This is a proposed fix, not actually tested. I used something similar for my wrappers.

Introspection queries should always resolve synchronously, and this wrapper causes them to be async. This causes problems when used in conjunction with Apollo.
@LennyPenny
Copy link

LennyPenny commented Nov 28, 2018

I really want to use this, can you package an npm version so I can better try this out?

Edit:
Okay building locally trying it out

@LennyPenny
Copy link

With that fix I managed to get it to work, however on startup this is spammed into the console

Cannot read property 'then' of undefined: 970516bc-4254-4f9f-8452-753291397f90
Cannot read property 'then' of undefined: 16901f6d-3ef8-450c-a7a7-b948c750b583
Cannot read property 'then' of undefined: 0d1e478f-4277-4120-b66c-4f049af07e11
Cannot read property 'then' of undefined: 478aaff1-5c17-4db9-ac61-a8fd6c401eb6
Cannot read property 'then' of undefined: 98a318d8-ac25-4f60-b039-931ddb7c6d2a
Cannot read property 'then' of undefined: 0b9e549a-d3e5-4b1c-9b76-12624591cf44
Cannot read property 'then' of undefined: 8e1f5bb5-ac2a-4c44-84b7-9df2b9f72993
Cannot read property 'then' of undefined: 47d66cf4-63c0-4500-9692-166a2b880135
Cannot read property 'then' of undefined: c595ffe6-beee-44a3-b24e-87d0f9721bef
Cannot read property 'then' of undefined: 1d84d871-f746-4c84-8afe-f2f8b1ebae39
Cannot read property 'then' of undefined: 917dbf91-e4cf-4bad-9d14-325828b1f74b
Cannot read property 'then' of undefined: 0fc46380-2a7a-4600-bb68-81511a246dba

@wmertens
Copy link
Author

@LennyPenny should be fixed now

Copy link

@LennyPenny LennyPenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out is still const, should be let out = ... on line 68

lib/index.js Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
@LennyPenny
Copy link

LennyPenny commented Nov 29, 2018

I will try this out tomorrow and report back, had to also do some other adjustments on my local fork but they might not really matter.

@arunoda get ready to merge & publish ;)

@crallan
Copy link

crallan commented Dec 18, 2018

Hi, when do you spect to have this merge and publish? I'm having this issue because I'm using graphql in conjunction with apollo.

Thanks

@LennyPenny
Copy link

@kadirahq could you test and merge this?

@wmertens
Copy link
Author

@kadirahq you realize that without this, your library can't be used with apollo-graphql?

@LennyPenny
Copy link

It looks like kadira has closed - @mnmtanish since you seem to have access to this, would you be able to test and merge this?
If not would you be wiling to let us fork this repo and point to the new repo in the readme of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants