-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain synchronicity of resolvers #18
base: master
Are you sure you want to change the base?
Conversation
Introspection queries should always resolve synchronously, and this wrapper causes them to be async. This causes problems when used in conjunction with Apollo.
I really want to use this, can you package an npm version so I can better try this out? Edit: |
With that fix I managed to get it to work, however on startup this is spammed into the console
|
@LennyPenny should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out
is still const
, should be let out = ...
on line 68
I will try this out tomorrow and report back, had to also do some other adjustments on my local fork but they might not really matter. @arunoda get ready to merge & publish ;) |
Hi, when do you spect to have this merge and publish? I'm having this issue because I'm using graphql in conjunction with apollo. Thanks |
@kadirahq could you test and merge this? |
@kadirahq you realize that without this, your library can't be used with apollo-graphql? |
It looks like kadira has closed - @mnmtanish since you seem to have access to this, would you be able to test and merge this? |
Introspection queries should always resolve synchronously, and this wrapper causes them to be async. This causes problems when used in conjunction with Apollo.
This is a proposed fix, not actually tested. I used something similar for my wrappers.