wip: implement writeFile and writeFileSync #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I've implemented a very early stage
writeFile
andwriteFileSync
. There's a few issues right now that I'd like to get some feedback ondata
should either bestring
orbytes
. I saw thatwrite
used onlybytes
, so I went with that for now. Should I add both, string and bytes or leave it just with bytes? If we decide to go withbytes
onlyencoding
would not be needed (which is why it's not being used right now).write
, since node api does not give anything other than the error. Should I return it?Tests are missing yet