Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- add mlflow support #29

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

- add mlflow support #29

wants to merge 5 commits into from

Conversation

vidma
Copy link
Contributor

@vidma vidma commented Aug 2, 2021

  • add inplace capabilities for DataFrame
  • add getitem support for numpy array
  • introducing aliases: sent datasources replace the in-mem one
  • sklearn: support of RandomForestClassifier
  • support of metrics: ROC computed in a new lineage

Signed-off-by: Sammy El Khammal [email protected]

- add inplace capabilities for DataFrame
- add getitem support for numpy array
- introducing aliases: sent datasources replace the in-mem one
- sklearn: support of RandomForestClassifier
- support of metrics: ROC computed in a new lineage

Signed-off-by: Sammy El Khammal <[email protected]>
@SammyEK SammyEK marked this pull request as ready for review October 5, 2021 09:37
ivanopagano
ivanopagano previously approved these changes Oct 6, 2021
Copy link

@ivanopagano ivanopagano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to contribute some comment

kensu/sklearn/ensemble.py Outdated Show resolved Hide resolved
@@ -1,3 +1,5 @@
import logging

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used?

@@ -1,13 +1,16 @@
import logging
import json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used?

- support of lineage for numpy _getitem_

Signed-off-by: Sammy El Khammal <[email protected]>
- support of lineage for numpy _getitem_
- bugfix lineage lost for _set_item

Signed-off-by: Sammy El Khammal <[email protected]>
FieldDef(name="coef_", field_type="array<float>", nullable=False)
]
logged_ds = DataSource(name=name,categories=['logical::'+name], format='MLFlow', pk=ds_pk)._report()
sc_pk = SchemaPK(logged_ds.to_ref(),
Copy link
Contributor Author

@vidma vidma Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use low level constructs over and over again. we could re-use helpers and have less code, less duplication, code easier to refactor and easier to read...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants