-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- add mlflow support #29
base: main
Are you sure you want to change the base?
Conversation
- add inplace capabilities for DataFrame - add getitem support for numpy array - introducing aliases: sent datasources replace the in-mem one - sklearn: support of RandomForestClassifier - support of metrics: ROC computed in a new lineage Signed-off-by: Sammy El Khammal <[email protected]>
Signed-off-by: Sammy El Khammal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to contribute some comment
@@ -1,3 +1,5 @@ | |||
import logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used?
@@ -1,13 +1,16 @@ | |||
import logging | |||
import json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used?
- support of lineage for numpy _getitem_ Signed-off-by: Sammy El Khammal <[email protected]>
- support of lineage for numpy _getitem_ - bugfix lineage lost for _set_item Signed-off-by: Sammy El Khammal <[email protected]>
FieldDef(name="coef_", field_type="array<float>", nullable=False) | ||
] | ||
logged_ds = DataSource(name=name,categories=['logical::'+name], format='MLFlow', pk=ds_pk)._report() | ||
sc_pk = SchemaPK(logged_ds.to_ref(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use low level constructs over and over again. we could re-use helpers and have less code, less duplication, code easier to refactor and easier to read...
Signed-off-by: Sammy El Khammal [email protected]