Add inner op #20532
Open
Add inner op #20532
+110
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20532 +/- ##
==========================================
+ Coverage 82.11% 82.13% +0.01%
==========================================
Files 515 515
Lines 47806 47846 +40
Branches 7490 7492 +2
==========================================
+ Hits 39258 39298 +40
Misses 6736 6736
Partials 1812 1812
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
fchollet
reviewed
Nov 23, 2024
| compute_dtype = dtypes.result_type(result_dtype, float) | ||
| x1 = tf.cast(x1, compute_dtype) | ||
| x2 = tf.cast(x2, compute_dtype) | ||
| return tf.cast(tf.experimental.numpy.inner(x1, x2), result_dtype) |
There was a problem hiding this comment.
Whenever possible we should avoid relying on tf.experimental.numpy. Can you just in-line the implementation here?
|
|
||
| Returns: | ||
| Output tensor. The shape of the output is determined by broadcasting the | ||
| shapes of x1 and x2 after removing their last axes. |
There was a problem hiding this comment.
Add backticks around code keywords.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inner product of two arrays.
@fchollet