feat: support custom seconds per slot and slots per epoch #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aimxhaisse
reviewed
Feb 15, 2024
| @@ -20,6 +20,7 @@ def process_future_blocks_proposal( | |||
| our_pubkeys: set[str], | |||
| slot: int, | |||
| is_new_epoch: bool, | |||
| slots_per_epoch: int = NB_SLOT_PER_EPOCH, | |||
There was a problem hiding this comment.
nit: It'd be better to not default to something here and unconditionally use the value from the spec ; happy to do a pass on top of your PR to force this parameter :)
aimxhaisse
reviewed
Feb 15, 2024
| @@ -29,6 +29,7 @@ def process_suboptimal_attestations( | |||
| block: Block, | |||
| slot: int, | |||
| our_active_validators_index_to_validator: dict[int, Validators.DataItem.Validator], | |||
| slots_per_epoch: int = NB_SLOT_PER_EPOCH, | |||
aimxhaisse
reviewed
Feb 15, 2024
| next_slot = int((time() - genesis_time_sec) / NB_SECOND_PER_SLOT) + 1 | ||
| def slots( | ||
| genesis_time_sec: int, | ||
| seconds_per_slot: int = NB_SECOND_PER_SLOT, |
|
Thanks a lot for your contribution and sorry for the delay on this review; happy to help with the comments / help moving this forward :) |
|
Just a quick update here, I'm revamping part of the watcher in #93 ; part of it introduces a configuration file and the seconds_per_slots will be configurable |
|
Just a quick note here: next version of the watcher (beta) polls the slot time from the ethereum specs of the beacon, so it will adapt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load
SLOTS_PER_EPOCHandSECONDS_PER_SLOTspecification params from Beacon API instead of using constants. This change gives support for Gnosis Chain based networks.