Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Issue #1256: List of guests should always show the link to access guest via VNC or Spice #1257

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Resolve Issue #1256: List of guests should always show the link to access guest via VNC or Spice #1257

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1068a64
Issue #1256: List of guests should always show the link to access gue…
mnsuccess Oct 11, 2018
782dbad
Remove comment ligne
mnsuccess Jul 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/css/kimchi.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,10 +960,11 @@
}
}

/*
#guest-content-container .wok-guest-list .wok-guest-list-header > span.column-vnc,
#guest-content-container .wok-guest-list .wok-guest-list-body .wok-guest-list-item > span.column-vnc {
display: none;
}
}*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of comment out code, could you remove it if it is not in use anymore.


#guest-content-container .wok-guest-list .wok-guest-list-header > span.column-vnc > a,
#guest-content-container .wok-guest-list .wok-guest-list-body .wok-guest-list-item > span.column-vnc > a {
Expand Down
2 changes: 1 addition & 1 deletion ui/pages/tabs/guests.html.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
<span class="column-state"><span class="sr-only">$_("State")</span></span><!--
--><span class="column-name"><span title="$_('Guest Name ID')">$_("Guest Name ID")</span></span><!--
--><span class="column-type"><span title="$_('OS Type')">$_("OS Type")</span></span><!--
--><span class="column-vnc"><span title="$_('VNC')">$_("VNC")</span></span><!--
--><span class="column-vnc"><span title="$_('VNC/Spice')">$_("VNC/Spice")</span></span><!--
--><span class="column-processors"><span title="$_('Processors Utilization')">$_("Processors Utilization")</span></span><!--
--><span class="column-memory"><span title="$_('Memory Utilization')">$_("Memory Utilization")</span></span><!--
--><span class="column-storage"><span title="$_('Storage I/O')">$_("Storage I/O")</span></span><!--
Expand Down